Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone submodules recursively #42928

Closed
wants to merge 1 commit into from
Closed

Clone submodules recursively #42928

wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link
Contributor

Partially for #42911
Not deeply tested.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@ishitatsuyuki
Copy link
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned aturon Jun 27, 2017
@Mark-Simulacrum Mark-Simulacrum requested a review from aidanhs June 27, 2017 13:50
@frewsxcv frewsxcv added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jun 27, 2017
@nagisa
Copy link
Member

nagisa commented Jun 27, 2017

This is also done by #42899, which seems like it is likely to be r+d fairly soon.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 27, 2017
Merged
@Mark-Simulacrum
Copy link
Member

Well, partially. I'm going to leave a comment there mentioning that the init_repo script needs updating as well

@nrc
Copy link
Member

nrc commented Jun 27, 2017

r? @alexcrichton

I've undone the submodule stuff in the RLS, so this is not necessary for the RLS now, but it might be good to have anyway?

@rust-highfive rust-highfive assigned alexcrichton and unassigned nrc Jun 27, 2017
@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2017
@alexcrichton
Copy link
Member

r? @aidanhs

@aidanhs
Copy link
Member

aidanhs commented Jun 27, 2017

I'm pretty confident this is going to be superseded by #42899 per #42899 (comment), but I really appreciate you raising this PR @ishitatsuyuki because it's provided a useful hint for what we need to change in init_repo.sh.

I'll close this PR if appropriate when the other one gets merged.

@bors
Copy link
Collaborator

bors commented Jul 2, 2017

☔ The latest upstream changes (presumably #43003) made this pull request unmergeable. Please resolve the merge conflicts.

@aidanhs
Copy link
Member

aidanhs commented Jul 6, 2017

This has been merged as part of #42899. Thanks again @ishitatsuyuki!

@aidanhs aidanhs closed this Jul 6, 2017
@ishitatsuyuki ishitatsuyuki deleted the subm-r branch July 6, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanhs aidanhs Awaiting requested review from aidanhs

Assignees

@aidanhs aidanhs

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.